[quick_actions_ios] Migrate XCTest to Swift Testing #10767

jmagman · 2026-01-10T06:50:56Z

◇ Test run started.
↳ Testing Library Version: 102 (arm64-apple-ios13.0-simulator)
◇ Suite QuickActionsPluginTests started.
◇ Test applicationDidBecomeActiveLaunchWithShortcut() started.
◇ Test handleMethodCallClearShortcutItems() started.
◇ Test applicationDidBecomeActiveLaunchWithoutShortcut() started.
◇ Test applicationPerformActionForShortcutItem() started.
◇ Test applicationDidBecomeActiveLaunchWithShortcutBecomeActiveTwice() started.
◇ Test applicationDidFinishLaunchingWithOptionsLaunchWithoutShortcut() started.
◇ Test handleMethodCallSetShortcutItems() started.
◇ Test applicationDidFinishLaunchingWithOptionsLaunchWithShortcut() started.
✔ Test applicationDidBecomeActiveLaunchWithShortcutBecomeActiveTwice() passed after 0.003 seconds.
✔ Test applicationDidBecomeActiveLaunchWithShortcut() passed after 0.003 seconds.
✔ Test applicationPerformActionForShortcutItem() passed after 0.003 seconds.
✔ Test applicationDidFinishLaunchingWithOptionsLaunchWithShortcut() passed after 0.003 seconds.
✔ Test applicationDidFinishLaunchingWithOptionsLaunchWithoutShortcut() passed after 0.003 seconds.
✔ Test handleMethodCallSetShortcutItems() passed after 0.003 seconds.
✔ Test handleMethodCallClearShortcutItems() passed after 0.003 seconds.
✔ Test applicationDidBecomeActiveLaunchWithoutShortcut() passed after 0.003 seconds.
✔ Suite QuickActionsPluginTests passed after 0.025 seconds.
✔ Test run with 8 tests passed after 0.026 seconds.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8692855180982743569/+/u/Run_package_tests/native_test/stdout

Adding CHANGELOG override per #10761 (comment)

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

gemini-code-assist

Code Review

This pull request migrates the iOS quick actions plugin tests from XCTest to the new Swift Testing framework. The changes involve updating the test file QuickActionsPluginTests.swift to use the new @Test macros, #expect assertions, and async testing features. The project's Swift version is also updated to 6.0 to support Swift Testing.

The migration is well-executed. I have one suggestion to improve the robustness of an asynchronous test to better align with the original test's logic and be less dependent on the mock's implementation details.

packages/quick_actions/quick_actions_ios/example/ios/RunnerTests/QuickActionsPluginTests.swift

jmagman · 2026-01-10T07:01:14Z

/gemini review

gemini-code-assist

Code Review

This pull request migrates the iOS quick actions example tests from XCTest to the new Swift Testing framework. The changes are generally correct and follow the new testing patterns. I've identified a few areas for improvement in the test file: some assertion messages that were present in the original tests have been lost, and one test can be made more robust to match its descriptive name. My detailed comments provide suggestions to address these points.

packages/quick_actions/quick_actions_ios/example/ios/RunnerTests/QuickActionsPluginTests.swift

gemini-code-assist

Code Review

This pull request successfully migrates the quick_actions_ios plugin's tests from XCTest to the new Swift Testing framework. The changes involve updating the Swift version and replacing XCTest APIs with their Swift Testing equivalents like @Test, #expect, and await confirmation. The test logic is correctly preserved, and in one case, improved for better correctness. My feedback is focused on enhancing the readability of the new test function names for better maintainability.

packages/quick_actions/quick_actions_ios/example/ios/RunnerTests/QuickActionsPluginTests.swift

…r/packages#10767)

flutter/packages@1cb2148...cd4fd61 2026-01-28 magder@google.com [quick_actions_ios] Migrate XCTest to Swift Testing (flutter/packages#10767) 2026-01-28 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Improve documentation on `cameraId` parameter (flutter/packages#10844) 2026-01-28 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Improve error messages when image capture fails (flutter/packages#10846) 2026-01-28 j.calvin.ren@gmail.com [image_picker] Transparent pressing on iOS 26 (#173453) (flutter/packages#10533) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#181663) flutter/packages@1cb2148...cd4fd61 2026-01-28 magder@google.com [quick_actions_ios] Migrate XCTest to Swift Testing (flutter/packages#10767) 2026-01-28 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Improve documentation on `cameraId` parameter (flutter/packages#10844) 2026-01-28 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Improve error messages when image capture fails (flutter/packages#10846) 2026-01-28 j.calvin.ren@gmail.com [image_picker] Transparent pressing on iOS 26 (flutter#173453) (flutter/packages#10533) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added p: quick_actions platform-ios labels Jan 10, 2026

jmagman mentioned this pull request Jan 10, 2026

Migrate iOS plugin tests from XCTest to Swift Testing flutter/flutter#180787

Open

19 tasks

gemini-code-assist bot reviewed Jan 10, 2026

View reviewed changes

packages/quick_actions/quick_actions_ios/example/ios/RunnerTests/QuickActionsPluginTests.swift Outdated Show resolved Hide resolved

jmagman force-pushed the quick-action-st branch from ae30d6a to 88d4558 Compare January 10, 2026 07:00

gemini-code-assist bot reviewed Jan 10, 2026

View reviewed changes

jmagman added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jan 14, 2026

[quick_actions_ios] Migrate XCTest to Swift Testing

a0b82f7

jmagman force-pushed the quick-action-st branch from fdfa666 to a0b82f7 Compare January 27, 2026 05:08

jmagman marked this pull request as ready for review January 27, 2026 05:35

jmagman requested review from LongCatIsLooong and LouiseHsu as code owners January 27, 2026 05:35

gemini-code-assist bot reviewed Jan 27, 2026

View reviewed changes

LongCatIsLooong approved these changes Jan 28, 2026

View reviewed changes

LouiseHsu approved these changes Jan 28, 2026

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2026

auto-submit bot merged commit cd4fd61 into flutter:main Jan 28, 2026
81 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2026

cd4fd61fc [quick_actions_ios] Migrate XCTest to Swift Testing (flutte…

2d2cff9

…r/packages#10767)

engine-flutter-autoroll mentioned this pull request Jan 29, 2026

Roll Packages from 1cb2148ade16 to cd4fd61fc5b6 (4 revisions) flutter/flutter#181663

Merged

jmagman deleted the quick-action-st branch February 2, 2026 20:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[quick_actions_ios] Migrate XCTest to Swift Testing #10767

[quick_actions_ios] Migrate XCTest to Swift Testing #10767

jmagman commented Jan 10, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

jmagman commented Jan 10, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[quick_actions_ios] Migrate XCTest to Swift Testing #10767

[quick_actions_ios] Migrate XCTest to Swift Testing #10767

Conversation

jmagman commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

jmagman commented Jan 10, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jmagman commented Jan 10, 2026 •

edited

Loading